pageserver: coalesce index uploads when possible #10248
Open
+62
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7227 tests run: 6873 passed, 0 failed, 354 skipped (full report)Flaky tests (2)Postgres 17
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
1568f90 at 2025-01-04T10:38:55.123Z :recycle: |
erikgrinaker
force-pushed
the
erik/upload-reorder
branch
9 times, most recently
from
91be562 to
dad6139
Compare
erikgrinaker
force-pushed
the
erik/upload-index-coalesce
branch
from
06f1d7a to
76698d5
Compare
erikgrinaker
force-pushed
the
erik/upload-reorder
branch
3 times, most recently
from
e207145 to
419019e
Compare
erikgrinaker
force-pushed
the
erik/upload-index-coalesce
branch
from
76698d5 to
9d54d23
Compare
erikgrinaker
force-pushed
the
erik/upload-reorder
branch
from
419019e to
e91e7e4
Compare
erikgrinaker
force-pushed
the
erik/upload-index-coalesce
branch
from
9d54d23 to
1568f90
Compare
VladLazar
approved these changes
Jan 6, 2025
That's right. |
Seems worth making that explicit, I'll add a condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With upload queue reordering in #10218, we can easily get into a situation where multiple index uploads are queued back to back, which can't be parallelized. This will happen e.g. when multiple layer flushes enqueue layer/index/layer/index/... and the layers skip the queue and are uploaded in parallel.
These index uploads will incur serial S3 roundtrip latencies, and may block later operations.
Resolves #10096.
Requires #10218.
Summary of changes
When multiple back-to-back index uploads are ready to upload, only upload the most recent index and drop the rest.